Skip to content

fix(web): align legacy thread metadata columns - #99

Merged
lastobelus merged 6 commits into
lastcode/mainfrom
lastcode/align-thread-icon-columns
Aug 27, 2026
Merged

fix(web): align legacy thread metadata columns#99
lastobelus merged 6 commits into
lastcode/mainfrom
lastcode/align-thread-icon-columns

Conversation

@lastobelus

@lastobelus lastobelus commented Aug 26, 2026

Copy link
Copy Markdown
Owner

The Legacy Sidebar environment icons were not actually aligned in scanning columns. Relative timestamp labels widened a flex container, so the worktree and environment icons shifted horizontally from row to row.\n\nThis replaces that flexible metadata area with fixed worktree, environment, and timestamp tracks. Empty worktree and local-icon cells remain mounted, while optional port and terminal indicators extend to the left without moving the scanning columns. The newer Show worktree indicators setting is preserved inside the fixed worktree track.\n\nVisual QA on the isolated shared web app:\n- authenticated app loaded successfully through vp run dev --share after rebasing onto PR #102\n- all 10 real Legacy Sidebar rows used identical worktree, environment, and timestamp coordinates\n- labels 2m ago, 42m ago, 1d ago, 17h ago, and just now left every column unchanged\n- local icon off left an aligned empty environment slot\n- local icon on filled that same slot without moving the worktree or timestamp columns\n- worktree icons off left an aligned empty worktree slot without moving environment icons or timestamps\n- original isolated settings were restored after testing\n\nValidation:\n- focused environment-icon tests: 10 passed\n- web typecheck: passed\n- LastCode quick local CI: passed on rebased head 59ade17\n- web tests: 2,856 passed\n- server tests: 2,838 passed, 7 skipped\n- all remaining workspace suites passed\n\nThe collaborative preview screenshot operation itself failed, so there is no after image attached; visual layout was verified from the rendered browser geometry rather than inferred from source.\n\nImplemented with GPT-5.6 Codex in the T3 Code harness.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2ba4c505b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx Outdated
@lastobelus
lastobelus force-pushed the lastcode/align-thread-icon-columns branch from d2ba4c5 to 59ade17 Compare August 27, 2026 08:10
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bc9b08319

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx Outdated
@lastobelus
lastobelus force-pushed the lastcode/align-thread-icon-columns branch from 6bc9b08 to d554b9a Compare August 27, 2026 08:53
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d554b9afca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx Outdated
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ed09c7773

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx Outdated
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c9b234dda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx
@lastobelus

lastobelus commented Aug 27, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 53c37c12e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 53c37c12e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus merged commit 953b281 into lastcode/main Aug 27, 2026
10 checks passed
@lastobelus
lastobelus deleted the lastcode/align-thread-icon-columns branch August 27, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant